[RFC PATCH 07/36] staging: comedi: adl_pci9111: convert driver to use the comedi_8254 module

Ian Abbott abbotti at mev.co.uk
Mon Feb 23 18:09:41 UTC 2015


On 20/02/15 23:04, H Hartley Sweeten wrote:
> This driver uses an 8254 timer to generate the pacer clock used for analog
> input data acquisition. Convert it to use the comedi_8254 module to provide
> support for the 8254 timer.
>
> Signed-off-by: H Hartley Sweeten <hsweeten at visionengravers.com>
> Cc: Ian Abbott <abbotti at mev.co.uk>
> Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> ---
>   drivers/staging/comedi/Kconfig               |  1 +
>   drivers/staging/comedi/drivers/adl_pci9111.c | 39 +++++++---------------------
>   2 files changed, 10 insertions(+), 30 deletions(-)
>
[snip]
> @@ -702,6 +676,11 @@ static int pci9111_auto_attach(struct comedi_device *dev,
>   			dev->irq = pcidev->irq;
>   	}
>
> +	dev->pacer = comedi_8254_init(dev->iobase + PCI9111_8254_BASE_REG,
> +				      I8254_OSC_BASE_2MHZ, I8254_IO16, 1);

Either this is wrong, or patch 01 is wrong, since the registers should 
be on 2-byte boundaries.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-


More information about the devel mailing list