[PATCH 0/6] Drivers: hv: vmbus
Dexuan Cui
decui at microsoft.com
Mon Feb 16 03:19:05 UTC 2015
> -----Original Message-----
> From: devel [mailto:driverdev-devel-bounces at linuxdriverproject.org] On Behalf
> Of K. Y. Srinivasan
> Sent: Monday, February 16, 2015 4:11 AM
> To: gregkh at linuxfoundation.org; linux-kernel at vger.kernel.org;
> devel at linuxdriverproject.org; olaf at aepfle.de; apw at canonical.com;
> vkuznets at redhat.com
> Subject: [PATCH 0/6] Drivers: hv: vmbus
>
> The host can rescind an offer any time after the offer has been made
> to the guest. This patch-set cleans up how we handle rescind messages
> from the host.
>
>
> K. Y. Srinivasan (6):
> Drivers: hv: vmbus: Properly handle child device remove
> Drivers: hv: vmbus: Introduce a function to remove a rescinded offer
> Drivers: hv: vmbus: Handle both rescind and offer messages in the
> same context
> Drivers: hv: vmbus: Remove the channel from the channel list(s) on
> failure
> Drivers: hv: util: On device remove, close the channel after
> de-initializing the service
> Drivers: hv: vmbus: Get rid of some unnecessary messages
>
> drivers/hv/channel.c | 9 ++++
> drivers/hv/channel_mgmt.c | 95 ++++++++++++++++++++------------------------
> drivers/hv/connection.c | 7 +---
> drivers/hv/hv_util.c | 2 +-
> drivers/hv/vmbus_drv.c | 26 +++++++++---
> include/linux/hyperv.h | 1 +
> 6 files changed, 74 insertions(+), 66 deletions(-)
>
> --
The patchset seems good to me.
Reviewed-by: Dexuan Cui <decui at microsoft.com>
BTW, IMO we need one more patch to remove the queue_work() in
free_channel() -- just make it an ordinary synchronous function call:
vmbus_process_offer() can invoke free_channel() on error path,
and vmbus_process_rescind() can invoke free_channel() too.
We should exclude the possible race.
And now the controlwq and work fields of struct vmbus_channel
are useless now.
Thanks,
-- Dexuan
More information about the devel
mailing list