[PATCH 01/30] staging: unisys: serverdown variable change bool to int virthba

[Dan Carpenter]

On Wed, Feb 11, 2015 at 08:32:52AM -0600, Romer, Benjamin M wrote:
> On Wed, 2015-02-11 at 11:36 +0300, Dan Carpenter wrote:
> > On Tue, Feb 10, 2015 at 12:58:35PM -0500, Benjamin Romer wrote:
> > > From: Erik Arfvidson <erik.arfvidson at unisys.com>
> > > 
> > > This patch changes serverdown variable to int instead of bool
> > > 
> > 
> > Why?  It looks like bool is more appropriate?
> 
> Hi Dan,
> 
> We had received some comments on our code that said that our BOOL
> typedef wasn't acceptable,

Because we already have the "bool" type.

> and that we really ought to be returning 0
> for success and error values in failure cases. By switching these to int
> we're taking a first step towards that.

True, but I'm not sure if these patches help us do that generally, and
especially here we're changed a struct member and not a return type...

regards,
dan carpenter