[PATCH 1/2] [media] mn88472: Deletion of an unnecessary check before the function call "release_firmware"
SF Markus Elfring
elfring at users.sourceforge.net
Sun Feb 1 19:16:01 UTC 2015
From: Markus Elfring <elfring at users.sourceforge.net>
Date: Sun, 1 Feb 2015 19:12:56 +0100
The release_firmware() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring at users.sourceforge.net>
---
drivers/staging/media/mn88472/mn88472.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/media/mn88472/mn88472.c b/drivers/staging/media/mn88472/mn88472.c
index 52de8f8..e7874ae 100644
--- a/drivers/staging/media/mn88472/mn88472.c
+++ b/drivers/staging/media/mn88472/mn88472.c
@@ -315,8 +315,7 @@ static int mn88472_init(struct dvb_frontend *fe)
return 0;
err:
- if (fw)
- release_firmware(fw);
+ release_firmware(fw);
dev_dbg(&client->dev, "failed=%d\n", ret);
return ret;
--
2.2.2
More information about the devel
mailing list