[PATCH V2 1/2] iio: meter: ade7754: add error handling in _reset and _stop_device

Jonathan Cameron jic23 at kernel.org
Sun Feb 1 10:02:41 UTC 2015


On 05/01/15 06:12, devendra.aaru wrote:
> On Sun, Jan 4, 2015 at 6:06 AM, Jonathan Cameron <jic23 at kernel.org> wrote:
>> On 02/01/15 09:02, Devendra Naga wrote:
>>> This patch adds the error handling for the value returned from
>>> ade7754_spi_read_reg_8. With this patch, the following randconfig
>>> warnings get fixed automatically.
>>>
>>> drivers/staging/iio/meter/ade7754.c:222:6: warning: ‘val’ may be used
>>> uninitialized in this function [-Wmaybe-uninitialized]
>>> drivers/staging/iio/meter/ade7754.c:368:6: warning: ‘val’ may be used
>>> uninitialized in this function [-Wmaybe-uninitialized]
>>>
>>> Signed-off-by: Devendra Naga <devendra.aaru at gmail.com>
>> Looks good to me.  A Hartmut reviewed the original patch I'll leave it
>> a few days to see if he wants to take a look at the update.
>>
>> Thanks,
>>
>> Jonathan
>>> ---
> 
> Thanks for the review Jonathan.
Applied to the togreg branch of iio.git.  These have missed the
merge window for this cycle (sorry, I forgot about them!)

Anyhow, will get queued up for after the window closes.

J
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 



More information about the devel mailing list