[jubin.john at intel.com: [PATCH] staging/rdma/hfi1: Fix error in hfi1 driver build]

ira.weiny ira.weiny at intel.com
Mon Dec 14 19:36:39 UTC 2015


Greg,

It looks like you missed this patch for 4.4-rc5

Could we get it included for rc6?

Thanks,
Ira

----- Forwarded message from Jubin John <jubin.john at intel.com> -----

From: Jubin John <jubin.john at intel.com>
To: <gregkh at linuxfoundation.org>, <devel at driverdev.osuosl.org>
CC: <linux-rdma at vger.kernel.org>, <dledford at redhat.com>,
	<mike.marciniszyn at intel.com>, <ira.weiny at intel.com>, <jubin.john at intel.com>
Subject: [PATCH] staging/rdma/hfi1: Fix error in hfi1 driver build
Date: Fri, 20 Nov 2015 18:13:08 -0500

hfi1 driver build fails with the following error:
In function ‘handle_receive_interrupt’:
error: implicit declaration of function ‘skip_rcv_packet’ [-Werror=implicit-function-declaration]
    last = skip_rcv_packet(&packet, thread);
    ^
This is due to the inclusion of the skip_rcv_packet() in the
CONFIG_PRESCAN_RXQ ifdef block. This function is independent of
CONFIG_PRESCAN_RXQ and should be outside this block.

Fixes: 82c2611daaf0 ("staging/rdma/hfi1: Handle packets with invalid RHF on context 0")
Reviewed-by: Mike Marciniszyn <mike.marciniszyn at intel.com>
Signed-off-by: Jubin John <jubin.john at intel.com>
---
 drivers/staging/rdma/hfi1/driver.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/rdma/hfi1/driver.c b/drivers/staging/rdma/hfi1/driver.c
index 4c52e78..3b7a707 100644
--- a/drivers/staging/rdma/hfi1/driver.c
+++ b/drivers/staging/rdma/hfi1/driver.c
@@ -633,6 +633,7 @@ next:
 		update_ps_mdata(&mdata, rcd);
 	}
 }
+#endif /* CONFIG_PRESCAN_RXQ */
 
 static inline int skip_rcv_packet(struct hfi1_packet *packet, int thread)
 {
@@ -659,7 +660,6 @@ static inline int skip_rcv_packet(struct hfi1_packet *packet, int thread)
 
 	return ret;
 }
-#endif /* CONFIG_PRESCAN_RXQ */
 
 static inline int process_rcv_packet(struct hfi1_packet *packet, int thread)
 {
-- 
1.7.1


----- End forwarded message -----


More information about the devel mailing list