[PATCH v8 02/55] [media] staging: omap4iss: get entity ID using media_entity_id()
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Sun Dec 6 03:18:12 UTC 2015
Hi Javier,
Thank you for the patch.
On Sunday 30 August 2015 00:06:13 Mauro Carvalho Chehab wrote:
> From: Javier Martinez Canillas <javier at osg.samsung.com>
>
> Assessing media_entity ID should now use media_entity_id() macro to
Did you mean "accessing" ?
> obtain the entity ID, as a next patch will remove the .id field from
> struct media_entity .
>
> So, get rid of it, otherwise the omap4iss driver will fail to build.
>
> Signed-off-by: Javier Martinez Canillas <javier at osg.samsung.com>
> Acked-by: Hans Verkuil <hans.verkuil at cisco.com>
> Signed-off-by: Mauro Carvalho Chehab <mchehab at osg.samsung.com>
With the typo fixed,
Acked-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> diff --git a/drivers/staging/media/omap4iss/iss.c
> b/drivers/staging/media/omap4iss/iss.c index 9bfb725b9986..e54a7afd31de
> 100644
> --- a/drivers/staging/media/omap4iss/iss.c
> +++ b/drivers/staging/media/omap4iss/iss.c
> @@ -607,7 +607,7 @@ static int iss_pipeline_disable(struct iss_pipeline
> *pipe, * crashed. Mark it as such, the ISS will be reset when
> * applications will release it.
> */
> - iss->crashed |= 1U << subdev->entity.id;
> + iss->crashed |= 1U << media_entity_id(&subdev->entity);
> failure = -ETIMEDOUT;
> }
> }
> diff --git a/drivers/staging/media/omap4iss/iss_video.c
> b/drivers/staging/media/omap4iss/iss_video.c index
> bae67742706f..25e9e7a6b99d 100644
> --- a/drivers/staging/media/omap4iss/iss_video.c
> +++ b/drivers/staging/media/omap4iss/iss_video.c
> @@ -784,7 +784,7 @@ iss_video_streamon(struct file *file, void *fh, enum
> v4l2_buf_type type) entity = &video->video.entity;
> media_entity_graph_walk_start(&graph, entity);
> while ((entity = media_entity_graph_walk_next(&graph)))
> - pipe->entities |= 1 << entity->id;
> + pipe->entities |= 1 << media_entity_id(entity);
>
> /* Verify that the currently configured format matches the output of
> * the connected subdev.
--
Regards,
Laurent Pinchart
More information about the devel
mailing list