[PATCH] staging: iio: adc: lpc32xx: use correct reutrn value

Jonathan Cameron jic23 at kernel.org
Mon Aug 31 15:13:44 UTC 2015


On 30/08/15 09:12, Peng Fan wrote:
> To lpc32xx_adc driver, when platform_get_resource or
> platform_get_irq failed, we should use -ENXIO as a
> return value, but not -EBUSY.
> 
> Signed-off-by: Peng Fan <van.freenix at gmail.com>
> Cc: Jonathan Cameron <jic23 at kernel.org>
> Cc: Hartmut Knaack <knaack.h at gmx.de>
> Cc: Lars-Peter Clausen <lars at metafoo.de>
> Cc: Peter Meerwald <pmeerw at pmeerw.net>
> Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> Cc: Tapasweni Pathak <tapaswenipathak at gmail.com>
Applied to the togreg branch of iio.git - initially pushed out as testing for
the autobuilders to play with it.

Thanks,

Jonathan
> ---
>  drivers/staging/iio/adc/lpc32xx_adc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/iio/adc/lpc32xx_adc.c b/drivers/staging/iio/adc/lpc32xx_adc.c
> index 5331c44..bcf4ebb 100644
> --- a/drivers/staging/iio/adc/lpc32xx_adc.c
> +++ b/drivers/staging/iio/adc/lpc32xx_adc.c
> @@ -137,7 +137,7 @@ static int lpc32xx_adc_probe(struct platform_device *pdev)
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	if (!res) {
>  		dev_err(&pdev->dev, "failed to get platform I/O memory\n");
> -		return -EBUSY;
> +		return -ENXIO;
>  	}
>  
>  	iodev = devm_iio_device_alloc(&pdev->dev, sizeof(*info));
> @@ -162,7 +162,7 @@ static int lpc32xx_adc_probe(struct platform_device *pdev)
>  	irq = platform_get_irq(pdev, 0);
>  	if (irq <= 0) {
>  		dev_err(&pdev->dev, "failed getting interrupt resource\n");
> -		return -EINVAL;
> +		return -ENXIO;
>  	}
>  
>  	retval = devm_request_irq(&pdev->dev, irq, lpc32xx_adc_isr, 0,
> 



More information about the devel mailing list