[PATCH V2] staging: dgnc: take lock when storing value in dgnc_poll_tick

Salah Triki salah.triki at acm.org
Wed Aug 19 19:44:08 UTC 2015


On Wed, Aug 19, 2015 at 10:36:14PM +0300, Dan Carpenter wrote:
> On Wed, Aug 19, 2015 at 07:11:55PM +0100, Salah Triki wrote:
> > poll_tick is declared global, so dgnc_driver_pollrate_store needs to take
> > the lock dgnc_poll_lock before modifying this variable. dgnc_poll_lock is
> > the appropriate lock, since it is intended for poll scheduling and
> > dgnc_poll_tick contains the poll rate. dgnc_poll_lock needs to be declared
> > not static and extern in order to be visible for dgnc_driver_pollrate_store.
> > 
> > Signed-off-by: Salah Triki <salah.triki at acm.org>
> > ---
> 
> Looks good.
> 
> Reviewed-by: Dan Carpenter <dan.carpenter at oracle.com>
> 
> Greg has closed the tree because of the pending merge window so it will
> take several weeks before he merges this.  No worries though.
> 
> regards,
> dan carpenter
> 

Thanx :)

best regards,
salah triki


More information about the devel mailing list