[PATCHv2 5/5] staging: wilc1000: replace MALLOC_WILC_BUFFER() macro to avoid possible memory leak
Raphaël Beamonte
raphael.beamonte at gmail.com
Mon Aug 17 23:15:57 UTC 2015
2015-08-17 15:41 GMT-04:00 Arend van Spriel <arend at broadcom.com>:
> Probable MACRO_WILC_BUFFER should be MALLOC_WILC_BUFFER here.
Good catch!
> There is really no need to print an error message here. kmalloc will blurb
> enough info when it fails.
Ok!
> So these buffers are globals? So does this driver support multiple devices,
> ie. how are these used when two wilc1000 supported devices are present.
Not sure. I mostly did code refactoring to have a clearer source code
and try to respect the kernel code style. I don't have a compatible
device to try and test it unfortunately.
Thanks for the feedback. I just sent a revised version of the patch
taking your comments into account.
More information about the devel
mailing list