[PATCH 8/9] staging: comedi: usbduxfast: remove (*do_cmd) MIN_SAMPLING_PERIOD check

H Hartley Sweeten hsweeten at visionengravers.com
Fri Aug 14 21:29:41 UTC 2015


The (*do_cmdtest) properly checks the MIN_SAMPLE_PERIOD. Remove the
redundant check in the (*do_cmd).

Signed-off-by: H Hartley Sweeten <hsweeten at visionengravers.com>
Cc: Ian Abbott <abbotti at mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
---
 drivers/staging/comedi/drivers/usbduxfast.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/staging/comedi/drivers/usbduxfast.c b/drivers/staging/comedi/drivers/usbduxfast.c
index 649d56e..3468c03 100644
--- a/drivers/staging/comedi/drivers/usbduxfast.c
+++ b/drivers/staging/comedi/drivers/usbduxfast.c
@@ -512,14 +512,6 @@ static int usbduxfast_ai_cmd(struct comedi_device *dev,
 	if (cmd->convert_src == TRIG_TIMER)
 		steps = (cmd->convert_arg * 30) / 1000;
 
-	if ((steps < MIN_SAMPLING_PERIOD) && (cmd->chanlist_len != 1)) {
-		dev_err(dev->class_dev,
-			"steps=%ld, scan_begin_arg=%d. Not properly tested by cmdtest?\n",
-			steps, cmd->scan_begin_arg);
-		up(&devpriv->sem);
-		return -EINVAL;
-	}
-
 	switch (cmd->chanlist_len) {
 	case 1:
 		/*
-- 
2.4.3



More information about the devel mailing list