[patch] staging: comedi: me4000: use bitwise AND instead of logical
Ian Abbott
abbotti at mev.co.uk
Fri Aug 14 10:29:05 UTC 2015
On 14/08/15 09:54, Dan Carpenter wrote:
> This was supposed to bitwise AND but there is a typo.
>
> Fixes: 1a02387063fb ('staging: comedi: me4000: remove 'board' from me4000_ai_insn_read()')
> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
>
> diff --git a/drivers/staging/comedi/drivers/me4000.c b/drivers/staging/comedi/drivers/me4000.c
> index 5aa1780..15a5320 100644
> --- a/drivers/staging/comedi/drivers/me4000.c
> +++ b/drivers/staging/comedi/drivers/me4000.c
> @@ -480,7 +480,7 @@ static int me4000_ai_insn_read(struct comedi_device *dev,
>
> entry = chan | ME4000_AI_LIST_RANGE(range);
> if (aref == AREF_DIFF) {
> - if (!(s->subdev_flags && SDF_DIFF)) {
> + if (!(s->subdev_flags & SDF_DIFF)) {
> dev_err(dev->class_dev,
> "Differential inputs are not available\n");
> return -EINVAL;
> @@ -559,7 +559,7 @@ static int me4000_ai_check_chanlist(struct comedi_device *dev,
> }
>
> if (aref == AREF_DIFF) {
> - if (!(s->subdev_flags && SDF_DIFF)) {
> + if (!(s->subdev_flags & SDF_DIFF)) {
> dev_err(dev->class_dev,
> "Differential inputs are not available\n");
> return -EINVAL;
>
Thanks for catching that.
Reviewed-by: Ian Abbott <abbotti at mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti at mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
More information about the devel
mailing list