[PATCH] staging/lustre: add annotations for user space pointers
Greg KH
greg at kroah.com
Sat Aug 8 21:31:40 UTC 2015
On Sat, Aug 08, 2015 at 11:42:16PM +0300, Tomas Melin wrote:
> user space input pointers need correct annotations.
>
> Signed-off-by: Tomas Melin <tomas.melin at iki.fi>
> ---
> drivers/staging/lustre/include/linux/libcfs/libcfs_ioctl.h | 4 ++--
> drivers/staging/lustre/lustre/libcfs/linux/linux-module.c | 6 +++---
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs_ioctl.h b/drivers/staging/lustre/include/linux/libcfs/libcfs_ioctl.h
> index f5d741f..b861fe7 100644
> --- a/drivers/staging/lustre/include/linux/libcfs/libcfs_ioctl.h
> +++ b/drivers/staging/lustre/include/linux/libcfs/libcfs_ioctl.h
> @@ -208,7 +208,7 @@ static inline int libcfs_ioctl_is_invalid(struct libcfs_ioctl_data *data)
>
> int libcfs_register_ioctl(struct libcfs_ioctl_handler *hand);
> int libcfs_deregister_ioctl(struct libcfs_ioctl_handler *hand);
> -int libcfs_ioctl_getdata(char *buf, char *end, void *arg);
> -int libcfs_ioctl_popdata(void *arg, void *buf, int size);
> +int libcfs_ioctl_getdata(char *buf, char *end, void __user *arg);
> +int libcfs_ioctl_popdata(void __user *arg, void *buf, int size);
This isn't going to work well at all, please see the mailing list
archives for why.
sorry,
greg k-h
More information about the devel
mailing list