[PATCH 2/2] staging: unisys: visornic: Convert to using napi

Neil Horman nhorman at tuxdriver.com
Sat Aug 1 23:46:47 UTC 2015


On Sat, Aug 01, 2015 at 08:55:09AM -0700, Greg KH wrote:
> On Sat, Aug 01, 2015 at 09:36:19AM -0400, Neil Horman wrote:
> > On Fri, Jul 31, 2015 at 09:41:10PM -0400, Neil Horman wrote:
> > > On Fri, Jul 31, 2015 at 06:56:33PM -0400, Benjamin Romer wrote:
> > > > From: Neil Horman <nhorman at redhat.com>
> > > > 
> > > > Switch the visornic over to use napi.  Currently there is a kernel
> > > > thread
> > > > that sits and waits on a wait queue to get notified of incoming virtual
> > > > interrupts. It would be nice if we could handle frame reception using
> > > > the
> > > > standard napi processing instead.  This patch creates our napi instance
> > > > and has the rx thread schedule it
> > > > 
> > > > Given that the unisys hypervisor currently requires that queue servicing
> > > > be done by a polling loop that wakes up every 2ms, lets instead also
> > > > convert that to a timer, which is simpler, and allows us to remove all
> > > > the thread starting and stopping code.
> > > > 
> > > > Signed-off-by: Neil Horman <nhorman at tuxdriver.com>
> > > > Signed-off-by: Benjamin Romer <benjamin.romer at unisys.com>
> > > 
> > > I assume you just didn't copy me on patch 1/2? I don't see it anywhere.
> > > 
> > > Neil
> > > 
> > 
> > Sorry, scratch that, it just showed up late.
> > 
> > for the series:
> > Acked-by: Neil Horman <nhorman at tuxdriver.com>
> 
> Why are you acking a series that you already signed off on?  That seems
> redundant...
> 
I suppose it is, but it always strikes me as a bit out of place when someone
else posts patches for you, so I thought you might like to know this was in fact
mine, so I acked it.  Feel free to ignore it.

Neil



More information about the devel mailing list