[PATCH] staging: lustre: fix ifnullfree.cocci warnings

kbuild test robot fengguang.wu at intel.com
Thu Apr 30 16:27:35 UTC 2015


drivers/staging/lustre/lustre/lov/lov_request.c:74:3-8: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.

 NULL check before some freeing functions is not needed.

 Based on checkpatch warning
 "kfree(NULL) is safe this check is probably not required"
 and kfreeaddr.cocci by Julia Lawall.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

CC: Julia Lawall <Julia.Lawall at lip6.fr>
Signed-off-by: Fengguang Wu <fengguang.wu at intel.com>
---

 lov_request.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/drivers/staging/lustre/lustre/lov/lov_request.c
+++ b/drivers/staging/lustre/lustre/lov/lov_request.c
@@ -70,8 +70,7 @@ void lov_finish_set(struct lov_request_s
 			OBDO_FREE(req->rq_oi.oi_oa);
 		if (req->rq_oi.oi_md)
 			OBD_FREE_LARGE(req->rq_oi.oi_md, req->rq_buflen);
-		if (req->rq_oi.oi_osfs)
-			kfree(req->rq_oi.oi_osfs);
+		kfree(req->rq_oi.oi_osfs);
 		kfree(req);
 	}
 


More information about the devel mailing list