[PATCH] i2o: fix simple_return.cocci warnings

kbuild test robot fengguang.wu at intel.com
Thu Apr 30 13:03:04 UTC 2015


drivers/staging/i2o/iop.c:777:1-3: WARNING: end returns can be simpified

 Simplify a trivial if-return sequence.  Possibly combine with a
 preceding function call.
Generated by: scripts/coccinelle/misc/simple_return.cocci

CC: Alan Cox <alan at linux.intel.com>
Signed-off-by: Fengguang Wu <fengguang.wu at intel.com>
---

 iop.c |    6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

--- a/drivers/staging/i2o/iop.c
+++ b/drivers/staging/i2o/iop.c
@@ -774,11 +774,7 @@ static int i2o_iop_online(struct i2o_con
 
 	/* In READY state */
 	osm_debug("%s: Attempting to enable...\n", c->name);
-	rc = i2o_iop_enable(c);
-	if (rc)
-		return rc;
-
-	return 0;
+	return i2o_iop_enable(c);
 };
 
 /**


More information about the devel mailing list