[PATCH] staging: rtl8712: return error directly

Gujulan Elango, Hari Prasath (H.) hgujulan at visteon.com
Thu Apr 30 09:41:29 UTC 2015


From: gregkh at linuxfoundation.org <gregkh at linuxfoundation.org>
Sent: Thursday, April 30, 2015 3:05 PM
To: Gujulan Elango, Hari Prasath (H.)
Cc: devel at driverdev.osuosl.org; Julia.Lawall at lip6.fr; dan.carpenter at oracle.com; Larry.Finger at lwfinger.net; florian.c.schilhabel at googlemail.com; Babu, Viswanathan (V.)
Subject: Re: [PATCH] staging: rtl8712: return error directly

On Thu, Apr 30, 2015 at 08:23:08AM +0000, Gujulan Elango, Hari Prasath (H.) wrote:
> Signed-off-by: Hari Prasath Gujulan Elango <hgujulan at visteon.com>
>
> return error directly to avoid unwanted branching where no cleanup
> is done.Also removes the ret variable.

signed-off-by goes below the description, not above it.

Please fix up and resend.

----

I have sent the v2 patch.
regards
hari


More information about the devel mailing list