[PATCH] staging: sm750: Fix the Makefile option error

[Sudip Mukherjee]

On Wed, Apr 22, 2015 at 02:30:56PM +0800, 陈华才 wrote:
> Hi, Sudip,
> 
> We also get a sm750 kernel driver from Silicon Motion (http://dev.lemote.com/files/upload/lm/kernel/testing/sm750fb.tar.gz), its Version is 1.0.8.
> 
> I'm not sure whether your driver (which has merged in staging) is newer than ours, but it seems yours is older (Because there are LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,10) in your driver, and there are LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,28) in our driver).
I have not yet seen the code but just a quick check of the readme gives
the impression that yours is a newer version than the one I got from
them. Adding Teddy Wang of Silicon Mortion in cc for his comments on
this. I think he will be the most competent person to comment which is
the best code to be used.

> 
> I think you know more about SM750 than us, so please look at my tarball, and if ours is better, please update the kernel driver. Thank you very much.

I am still working with SM712 (sm7xxfb) and not started with SM750 yet.
Few more things are pending with sm7xxfb, after that i will place the
request to merge it with fbdev and will start with SM750.
Are you using SM750 in any of your products? I knew that you have been
using SM712 in your Yeeloong series.

And I have a request: will it be possible for you to check my next SM712
patch in an Yeeloong... I tried to purchase one for my testing, but the
price in our indian currency was too high and since this I do just for
my interest and not part of my dayjob, so there is no funding also :(

regards
sudip

> 
> Huacai
>  
> ------------------ Original ------------------
> From:  "Sudip Mukherjee"<sudipm.mukherjee at gmail.com>;
> Date:  Wed, Apr 22, 2015 12:59 PM
> To:  "Binbin Zhou"<zhoubb at lemote.com>; 
> Cc:  "Greg Kroah-Hartman"<gregkh at linuxfoundation.org>; "devel"<devel at driverdev.osuosl.org>; "Huacai Chen"<chenhc at lemote.com>; "Fuxin Zhang"<zhangfx at lemote.com>; 
> Subject:  Re: [PATCH] staging: sm750: Fix the Makefile option error
> 
>  
> On Wed, Apr 22, 2015 at 11:37:26AM +0800, Binbin Zhou wrote:
> > The sm750fb's Kconfig option is CONFIG_FB_SM750, not CONFIG_FB_SM7XX.
> > Thus fix it to make the sm750fb can be built successfully.
> 
> I always used to build sm750fb and sm7xxfb together, so failed to notice
> the error. thanks.
> 
> Acked-by: Sudip Mukherjee <sudip at vectorindia.org>