[PATCH] Staging: dgnc: Using temporary value for repeated dereferences.

Dan Carpenter dan.carpenter at oracle.com
Mon Apr 20 08:27:46 UTC 2015


On Sun, Apr 19, 2015 at 11:58:53PM +0200, Yorick Rommers wrote:
> Hello Joe,
> 
> Thank you once again for the feedback.
> I've changed my patch accordingly, see below.
> 
> --------------------------------------

The patch is nice except for this chunk.  And also you should be putting
version numbers in the patch description:

[PATCH v4] Staging: dgnc: Using temporary variable to save space

> 
> A patch for a line being too long (>80) in dgnc_mgmt.c,
> fixed by making a temporary value for dgnc_Board[brd],
> replacing all instanced of dgnc_Board[brd] with temporary value,
> and removing unnecessary typecasts.
> 
> Signed-off-by: Yorick Rommers <yorick-rommers at hotmail.com>
> ---

And put a note under the cut off here.

---
v4: Removed email to Joe Perches from the patch description

regards,
dan carpenter



More information about the devel mailing list