[PATCH 3/3] staging: dgnc: improve the coding style in unlocking part of dgnc_tty_write()
Dan Carpenter
dan.carpenter at oracle.com
Tue Apr 7 08:19:53 UTC 2015
On Tue, Apr 07, 2015 at 11:17:48AM +0300, Dan Carpenter wrote:
> This patch changes the lock ordering (behavior change) and it's not
> described in the changelog. Please figure out which way is the correct
> ordering and resend.
Actually the original ordering was obviously correct. You can't take
a mutex if you are holding a spinlock. So it always has to be:
mutex_lock();
spin_lock();
spin_unlock();
mutext_unlock();
regards,
dan carpenter
More information about the devel
mailing list