[PATCH] Staging: sm750fb: Remove extra parentheses around right bit shift operation

Amitoj Kaur Chawla amitoj1606 at gmail.com
Sun Apr 5 01:41:47 UTC 2015


Removes extra parentheses around bitwise right shift operation.

The issue was detected using the following coccinelle script.
@@
expression e, e1;
constant c;
@@

e =
-(e1
+e1
<<
-c);
+c;

@@
identifier i;
constant c;
type t;
expression e;
@@

t i =
-(e
+e
<<
-c);
+c;

@@
expression e, e1;
identifier f;
constant c;
@@

e1 = f(...,
-(e
+e
<<
-c)
+c
,...);


Signed-off-by: Amitoj Kaur Chawla <amitoj1606 at gmail.com>
---
 drivers/staging/sm750fb/sm750.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 4074375..626b841 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -737,7 +737,7 @@ static int sm750fb_set_drv(struct lynxfb_par * par)
                 output->paths = sm750_crt;
                 crtc->channel = sm750_secondary;
                 /* not consider of padding stuffs for oScreen,need fix*/
-                crtc->oScreen = (share->vidmem_size >> 1);
+                crtc->oScreen = share->vidmem_size >> 1;
                 crtc->vScreen = share->pvMem + crtc->oScreen;
             }
             break;
@@ -751,7 +751,7 @@ static int sm750fb_set_drv(struct lynxfb_par * par)
                 output->paths = sm750_crt;
                 crtc->channel = sm750_primary;
                 /* not consider of padding stuffs for oScreen,need fix*/
-                crtc->oScreen = (share->vidmem_size >> 1);
+                crtc->oScreen = share->vidmem_size >> 1;
                 crtc->vScreen = share->pvMem + crtc->oScreen;
             }
             break;
-- 
1.9.1



More information about the devel mailing list