[PATCH 1/1] Drivers: net-next: hyperv: Fix a bug in netvsc_start_xmit()

KY Srinivasan kys at microsoft.com
Mon Sep 29 03:51:32 UTC 2014



> -----Original Message-----
> From: David Miller [mailto:davem at davemloft.net]
> Sent: Sunday, September 28, 2014 8:17 PM
> To: KY Srinivasan
> Cc: netdev at vger.kernel.org; linux-kernel at vger.kernel.org;
> devel at linuxdriverproject.org; olaf at aepfle.de; apw at canonical.com;
> jasowang at redhat.com; stable at vger.kernel.org
> Subject: Re: [PATCH 1/1] Drivers: net-next: hyperv: Fix a bug in
> netvsc_start_xmit()
> 
> From: "K. Y. Srinivasan" <kys at microsoft.com>
> Date: Sun, 28 Sep 2014 19:49:51 -0700
> 
> > After the packet is successfully sent, we should not touch the skb as
> > it may have been freed. This patch is based on the work done by Long
> > Li <longli at microsoft.com>.
> >
> > Signed-off-by: K. Y. Srinivasan <kys at microsoft.com>
> > Tested-by: Long Li <longli at microsoft.com>
> > Cc: <stable at vger.kernel.org>
> 
> You hyperv guys really have to get your act together.  This is not properly
> submitted.
> 
> Most importantly, this is a serious reference to free memory bug.
> Therefore it should be targetted at 'net' not 'net-next'.
> 
> Secondly, you do not CC: stable for networking changes, you instead ask me
> to queue it up for my next batch of -stable networking changes.
> 
> Thirdly, your Subject line is malformed.  You should not use
> "Drivers: " as a prefix.  Just the driver name is sufficient.
> You should also not mentionen the target GIT tree outside of the [PATCH ...]
> bracketed area.
> 
> Also, please be cognizant of how much of my time you unnecessarily
> consume when you make a malformed submission like this.  That is time I
> could spend reviewing other patches.

Sorry about that; I will resubmit this patch after addressing all the issues you have raised.

Regards,

K. Y


More information about the devel mailing list