[PATCH 0/9] staging: unisys: checkpatch strict cleanup in include

Romer, Benjamin M Benjamin.Romer at unisys.com
Thu Sep 25 13:22:15 UTC 2014


On Thu, 2014-09-25 at 00:02 +0200, Greg KH wrote:
> On Wed, Sep 24, 2014 at 07:12:03PM +0300, Dan Carpenter wrote:
> > Gar.  I hate to make you redo a lot of work but these need to be broken
> > up into "one thing per patch".  That rules is kind of vague so we
> > normally tell people to fix one type of checkpatch.pl warning at a time
> > as a simple way of explaining it.
> > 
> > But definitely "fixing every checkpatch.pl warning in a file" is not
> > one thing unless there are like 2 lines of change only.
> 
> I agree, please fix this up into "one logical change per patch".
> 
> thanks,
> 
> greg k-h

That's no problem, the same amount of work needs to get done regardless
of how it's split up. :)

When you say type of warning, do you mean individual warnings, or can I
group them into sets, i.e. fixing spacing and doubled blank lines
together as a single whitespace formatting patch?

When fixing the camel-case warnings do I need to do a separate patch for
each function or variable or struct, or can I group all of the
camel-case fixes for a single file together?

-- Ben


More information about the devel mailing list