[PATCH 0/9] staging: unisys: checkpatch strict cleanup in include

Greg KH gregkh at linuxfoundation.org
Wed Sep 24 22:02:11 UTC 2014


On Wed, Sep 24, 2014 at 07:12:03PM +0300, Dan Carpenter wrote:
> Gar.  I hate to make you redo a lot of work but these need to be broken
> up into "one thing per patch".  That rules is kind of vague so we
> normally tell people to fix one type of checkpatch.pl warning at a time
> as a simple way of explaining it.
> 
> But definitely "fixing every checkpatch.pl warning in a file" is not
> one thing unless there are like 2 lines of change only.

I agree, please fix this up into "one logical change per patch".

thanks,

greg k-h


More information about the devel mailing list