[PATCH v3 0/8] comedi: ni_usb6501: add counter support

[Hartley Sweeten]

On Friday, September 19, 2014 4:51 AM, Luca Ellero wrote:
> This series of patches add counter support for NI USB-6501. I tested it on my
> device and it works fine.
>
> Changes for v2:
> - rewrite patch 3/9 changelog: replace "fix" with "cleanup"
> - avoid sparse warnings
> - add SDF_LSAMPL flag to counter subdevice
>
> Changes for v3:
> - remove useless checks
> - remove empty lines
> - ni6501_auto_attach(): replace spaces with tabs for proper alignment
> - squash last 5 patches into a single patch (add counter subdevice) to avoid 
>   compilation warnings "function defined but not used"
> - rename "counter" local vars to "val" to avoid ambiguity with counter number
> - let ni6501_cnt_insn_config() return the insn->n value if it succeeds
> - let ni6501_cnt_insn_read read insn->n values
> - let ni6501_cnt_insn_write be able to handle an array of values
>
> Luca Ellero (8):
>   staging: comedi: ni_usb6501: add counter commands
>   staging: comedi: ni_usb6501: update comments
>   staging: comedi: ni_usb6501: cleanup response_size
>   staging: comedi: ni_usb6501: replace spaces with tabs
>   staging: comedi: ni_usb6501: remove useless check
>   staging: comedi: ni_usb6501: remove empty lines
>   staging: comedi: ni_usb6501: rename ni6501_send_command()
>   staging: comedi: ni_usb6501: add counter subdevice
>
>  drivers/staging/comedi/drivers/ni_usb6501.c |  260 +++++++++++++++++++++++----
>  1 file changed, 228 insertions(+), 32 deletions(-)

Looks good. Thanks for doing this.

Reviewed-by: H Hartley Sweeten <hsweeten at visionengravers.com>