[PATCH v2 9/9] staging: comedi: ni_usb6501: add counter subdevice

[Hartley Sweeten]

On Tuesday, September 16, 2014 4:40 AM, Luca Ellero wrote:
> Signed-off-by: Luca Ellero <luca.ellero at brickedbrain.com>
> ---
>  drivers/staging/comedi/drivers/ni_usb6501.c |   12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/ni_usb6501.c b/drivers/staging/comedi/drivers/ni_usb6501.c
> index 791058d..8299e524 100644
> --- a/drivers/staging/comedi/drivers/ni_usb6501.c
> +++ b/drivers/staging/comedi/drivers/ni_usb6501.c
> @@ -576,7 +576,7 @@ static int ni6501_auto_attach(struct comedi_device *dev,
>  	sema_init(&devpriv->sem, 1);
>  	usb_set_intfdata(intf, devpriv);
>  
> -	ret = comedi_alloc_subdevices(dev, 1);
> +	ret = comedi_alloc_subdevices(dev, 2);
> 	if (ret)
> 		return ret;
> 
>@@ -590,6 +590,16 @@ static int ni6501_auto_attach(struct comedi_device *dev,

No issues with this patch, but a nit-pick...

> 	s->insn_bits = ni6501_dio_insn_bits;

You are missing a tab in the line above to align the '='.
This should be addressed in a separate patch.

Regards,
Hartley