[PATCH 3/9] staging: comedi: ni_usb6501: fix response_size

Luca Ellero luca.ellero at brickedbrain.com
Tue Sep 16 09:23:33 UTC 2014


Hi Dan,

Il 15/09/2014 15:16, Dan Carpenter wrote:
> On Mon, Sep 15, 2014 at 02:59:33PM +0200, Luca Ellero wrote:
>> Fix response_size in ni6501_send_command (READ_PORT command)
>
> This isn't a fix, it's a cleanup.  A fix is something that fixes a bug.
> We are sloppy about correcting newbies who are always writing checkpatch
> "fixes"...  There is an endless stream of newbies so I gave up
> correcting them long ago.
>
> Anyway the changelog is bad because it says it is a bugfix, but it
> doesn't give the before size or the after size or tell what the problem
> was or the implications of the bug.
>

You're right. response_size remains the same (no logical/functional 
change introduced at all).
I'll correct the changelog and resend.
Thanks
Regards
Luca




-- 
Luca Ellero

E-mail: luca.ellero at brickedbrain.com
Internet: www.brickedbrain.com



More information about the devel mailing list