[PATCH 1/2] mfd: rtsx: fix PM suspend for 5227
Dan Carpenter
dan.carpenter at oracle.com
Fri Sep 12 08:36:27 UTC 2014
On Thu, Sep 11, 2014 at 10:42:49AM +0300, Dan Carpenter wrote:
> On Thu, Sep 11, 2014 at 03:17:52PM +0800, micky_ching at realsil.com.cn wrote:
> > + err = pci_read_config_byte(pcr->pci, addr, &val);
> > + if (err)
> > + return err;
>
> Some of these check for "if (err) " and some check for "if (err < 0) ".
> What is the significance of that? I'm a newbie here. Did you mean for
> them to be different?
You've updated them all to be "if (err < 0)" how is that different from
"if (err)"? What I'm saying is that could you reply to the question?
I guess I normally prefer "if (err)" over "if (err < 0)" but I don't
know if it makes a difference here?
regards,
dan carpenter
>
More information about the devel
mailing list