[PATCH 1/3] staging: lustre: fix function definition style

Greg KH gregkh at linuxfoundation.org
Mon Sep 8 19:40:03 UTC 2014


On Sat, Sep 06, 2014 at 01:38:27PM -0400, Spencer Baugh wrote:
> Fix errors reported by checkpatch of this kind:
> ERROR: open brace '{' following function declarations go on the next line
> 
> Signed-off-by: Spencer Baugh <sbaugh at andrew.cmu.edu>
> ---
>  drivers/staging/lustre/lustre/include/lustre_import.h | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/include/lustre_import.h b/drivers/staging/lustre/lustre/include/lustre_import.h
> index 8304a55..feb4291 100644
> --- a/drivers/staging/lustre/lustre/include/lustre_import.h
> +++ b/drivers/staging/lustre/lustre/include/lustre_import.h
> @@ -346,21 +346,24 @@ static inline unsigned int at_timeout2est(unsigned int val)
>  	return (max((val << 2) / 5, 5U) - 4);
>  }
>  
> -static inline void at_reset(struct adaptive_timeout *at, int val) {
> +static inline void at_reset(struct adaptive_timeout *at, int val) 

You are adding whitespace errors with this patch, I can't take this
series because of this :(

Please always run your patches through scripts/checkpatch.pl to ensure
you aren't adding new problems.

Can you fix this series of patches up and resend?

thanks,

greg k-h


More information about the devel mailing list