[PATCH] unisys: Fix sparse error - accessing __iomem directly

Romer, Benjamin M Benjamin.Romer at unisys.com
Mon Sep 8 16:20:01 UTC 2014


On Mon, 2014-09-08 at 17:04 +0300, Dan Carpenter wrote:
> On Mon, Sep 08, 2014 at 01:44:49PM +0100, Luke Hart wrote:
> > Copy the channel type into a temporary buffer so that code will work for architectures that don't support MMIO. This now works in same way as other tests in same function.
> > 
> > Re-sent since I initially didn't copy devel at driverdev.osuosl.org and sparmaintainer at unisys.com doesn't seem to be a mailing list (despite what get_maintainer.pl indicates). 
> 
> The MAINTAINERS entry is:
> L:     sparmaintainer at unisys.com (Unisys internal)
> 
> I believe that it actually is a private list as described.  We discussed
> the sparmaintainer email address in the past.

Yes, this is an internal address that goes to several people inside of
Unisys.

> Otherwise the change seems sensible to me but I'm not terribly familiar
> with the code so I'll defer to Ben on this.

It looks good to me as well, and I can test it on x86_64, however the
s-Par firmware only runs on Intel 64-bit systems so there's no way to
test it on another architecture. A successful compilation is all I can
give you there.

-- Ben


More information about the devel mailing list