[PATCH] unisys: Fix sparse error - accessing __iomem directly

Dan Carpenter dan.carpenter at oracle.com
Mon Sep 8 14:04:29 UTC 2014


On Mon, Sep 08, 2014 at 01:44:49PM +0100, Luke Hart wrote:
> Copy the channel type into a temporary buffer so that code will work for architectures that don't support MMIO. This now works in same way as other tests in same function.
> 
> Re-sent since I initially didn't copy devel at driverdev.osuosl.org and sparmaintainer at unisys.com doesn't seem to be a mailing list (despite what get_maintainer.pl indicates). 

The MAINTAINERS entry is:
L:     sparmaintainer at unisys.com (Unisys internal)

I believe that it actually is a private list as described.  We discussed
the sparmaintainer email address in the past.

You should also CC Greg.

The obvious review comment is that the changelog needs to be line
wrapped at 72 characters.  Don't add the "Re-sent " stuff to the
permanent changelog because it's unrelated to your patch.  Put a
"Staging: " in your subject.

Otherwise the change seems sensible to me but I'm not terribly familiar
with the code so I'll defer to Ben on this.

regards,
dan carpenter



More information about the devel mailing list