[PATCH v2 6/6] staging: goldfish: avoid multiple assignments

Loic Pefferkorn loic at loicp.eu
Wed Sep 3 20:23:15 UTC 2014


Coding style: avoid multiple assignments

Signed-off-by: Loic Pefferkorn <loic at loicp.eu>
---
 drivers/staging/goldfish/goldfish_nand.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/goldfish/goldfish_nand.c b/drivers/staging/goldfish/goldfish_nand.c
index c6c85d3..d68f216 100644
--- a/drivers/staging/goldfish/goldfish_nand.c
+++ b/drivers/staging/goldfish/goldfish_nand.c
@@ -329,9 +329,10 @@ static int goldfish_nand_init_device(struct platform_device *pdev,
 
 	mtd->priv = nand;
 
-	mtd->name = name = devm_kzalloc(&pdev->dev, name_len + 1, GFP_KERNEL);
+	name = devm_kzalloc(&pdev->dev, name_len + 1, GFP_KERNEL);
 	if (name == NULL)
 		return -ENOMEM;
+	mtd->name = name;
 
 	result = goldfish_nand_cmd(mtd, NAND_CMD_GET_DEV_NAME, 0, name_len,
 				   name);
-- 
2.0.4



More information about the devel mailing list