[PATCH 01/12] Staging: rtl8821ae: hal_bt_coexist: fix commenting style
An Tuan Ha
zero579911 at gmail.com
Tue Sep 2 11:22:12 UTC 2014
I see, thanks, I will fix it, I was just worried about the subjects
being too long so I just stuck with the same subject; is there a
character limit on how long the subject line should be? Or as long as
it's reasonable, it'll be fine?
On Tue, Sep 02, 2014 at 12:19:40PM +0300, Dan Carpenter wrote:
> Hm... Now you've broken it into *too* many separate patches. Also the
> subjects are the same. Also the subjects are too vague. Which coding
> style issue is addressed?
>
> It should be something like:
> patch 1: comments
> patch 2: add/remove spaces
> patch 3: fix quoted text
> patch 4: braces
> patch 5: add a blank line
>
> regards,
> dan carpenter
>
More information about the devel
mailing list