[PATCH 3/4] staging: rtl8188eu: osdep_intf.h and usb_intf.c

Miguel Oliveira cmroliv at gmail.com
Mon Sep 1 11:55:52 UTC 2014


>> > Same comments as the previous ones, please redo all of these patches.
>> >
>> Should all the alterations be in one big single patch, insted of small ones?
>
> Your first version broke the build if we applied only the first patch.
> That's not allowed.
I now understand that, thank you.

> Also the new rtw_sys_remove_one() function isn't called.  I was confused
> by it as well.  It doesn't "remove one", it removes everything.
The function it's not new, I just converted it from the proc to
defugfs, It can be renamed.

> Do we need to support llseek?
Probably not... I'll check it.

> How have you tested this?  Have you tested module unloading?
Yes, I've tested it several times and unloaded without issues.

Thank you for your comments,
Best Regards,
Miguel Oliveira


More information about the devel mailing list