[PATCH 3/3] staging: comedi: drivers: digital output subdevices do not need SDF_READABLE

Ian Abbott abbotti at mev.co.uk
Fri Oct 31 12:14:00 UTC 2014


On 31/10/14 10:25, Ian Abbott wrote:
> On 30/10/14 18:19, H Hartley Sweeten wrote:
>> The SDF_READABLE flag is not necessary for digital output subdevices. For
>> consistency, remove this flag from the comedi drivers that set it.
>>
>> Signed-off-by: H Hartley Sweeten <hsweeten at visionengravers.com>
>> Cc: Ian Abbott <abbotti at mev.co.uk>
>> Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
>> ---
>>   drivers/staging/comedi/drivers/adl_pci9111.c  | 2 +-
>>   drivers/staging/comedi/drivers/amplc_pc263.c  | 2 +-
>>   drivers/staging/comedi/drivers/amplc_pci263.c | 2 +-
>>   drivers/staging/comedi/drivers/cb_pcidas64.c  | 2 +-
>>   drivers/staging/comedi/drivers/das08.c        | 2 +-
>>   drivers/staging/comedi/drivers/das16m1.c      | 2 +-
>>   drivers/staging/comedi/drivers/das1800.c      | 2 +-
>>   drivers/staging/comedi/drivers/das800.c       | 2 +-
>>   drivers/staging/comedi/drivers/icp_multi.c    | 2 +-
>>   9 files changed, 9 insertions(+), 9 deletions(-)
>>
> [snip]
>
>> diff --git a/drivers/staging/comedi/drivers/icp_multi.c
>> b/drivers/staging/comedi/drivers/icp_multi.c
>> index f9aa6a5..a412394 100644
>> --- a/drivers/staging/comedi/drivers/icp_multi.c
>> +++ b/drivers/staging/comedi/drivers/icp_multi.c
>> @@ -512,7 +512,7 @@ static int icp_multi_auto_attach(struct
>> comedi_device *dev,
>>
>>       s = &dev->subdevices[3];
>>       s->type = COMEDI_SUBD_DO;
>> -    s->subdev_flags = SDF_WRITABLE | SDF_READABLE;
>> +    s->subdev_flags = SDF_WRITABLE;
>>       s->n_chan = 8;
>>       s->maxdata = 1;
>>       s->len_chanlist = 8;
>>
>
> Not sure about icp_multi as the insn_bits handler actually reads data
> back from the hardware registers.  It may be doing something weird as it
> writes to a digital output register and reads back a digital input
> register which is referred to as "R/W: Digital inouts" in the comment.
> This needs a little investigation.

The little information I've managed to find suggests they are regular 
digital outputs (although with 24V outputs), so I guess they can be 
treated as non-readable.

I'll add the reviewed-by tag in a separate post.


-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-


More information about the devel mailing list