[PATCH] staging:rtl8723au: core: Fix error reported by checkpatch.
Sanjeev_Sharma at mentor.com
Wed Oct 29 06:32:48 UTC 2014
From: Jes Sorensen [mailto:Jes.Sorensen at redhat.com]
Sent: Monday, October 27, 2014 2:13 PM
To: Sharma, Sanjeev
Cc: Larry.Finger at lwfinger.net; gregkh at linuxfoundation.org; linux-wireless at vger.kernel.org; devel at driverdev.osuosl.org; linux-kernel at vger.kernel.org
Subject: Re: [PATCH] staging:rtl8723au: core: Fix error reported by checkpatch.
Sanjeev Sharma <sanjeev_sharma at mentor.com> writes:
> This is a patch to the rtw_cmd.c file that fixes Error reported by
> Signed-off-by: Sanjeev Sharma <Sanjeev_Sharma at mentor.com>
> drivers/staging/rtl8723au/core/rtw_cmd.c | 83
> 1 file changed, 40 insertions(+), 43 deletions(-)
> diff --git a/drivers/staging/rtl8723au/core/rtw_cmd.c
> index 4eaa502..c1f6254 100644
> --- a/drivers/staging/rtl8723au/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723au/core/rtw_cmd.c
> @@ -957,7 +957,7 @@ static void traffic_status_watchdog(struct rtw_adapter *padapter)
> /* check traffic for powersaving. */
> if (((pmlmepriv->LinkDetectInfo.NumRxUnicastOkInPeriod +
> pmlmepriv->LinkDetectInfo.NumTxOkInPeriod) > 8) ||
> - pmlmepriv->LinkDetectInfo.NumRxUnicastOkInPeriod >2)
> + pmlmepriv->LinkDetectInfo.NumRxUnicastOkInPeriod > 2)
> bEnterPS = false;
> bEnterPS = true;
This makes the line longer than 80 characters, that is worse than the 'problem' you are fixing.
How it can be worse because checkpatch treating this as an Error and line longer than 80 character is warning reported by checkpatch and I could see that in entire staging directory,
every maintainer most of the time ignore the 80 column limit and give priority to Error.
Please let me know your comment .
More information about the devel