[RFC] stating: ion: use hot page first in pool

Gioh Kim gioh.kim at lge.com
Wed Oct 29 04:57:15 UTC 2014


I found that ion insert freed-page at the tail of list
and extract at the head.

I think it is good for cache to use the most recently used page
but these pages in pool are not cached memory.
So I'm not sure using hot page is better or not in this case.

What do you think about using hot page first?

-------------------------- 8< -----------------------------

>From 14c8455cc80628e56a27ace9603d29e5056835b5 Mon Sep 17 00:00:00 2001
From: Gioh Kim <gioh.kim at lge.com>
Date: Wed, 29 Oct 2014 13:44:28 +0900
Subject: [PATCH] staging: ion: use hot-page first

A page near the head is hot for cache.
This patch makes pool use hot page first.

Signed-off-by: Gioh Kim <gioh.kim at lge.com>
 drivers/staging/android/ion/ion_page_pool.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/android/ion/ion_page_pool.c b/drivers/staging/android/ion/ion_page_pool.c
index 5864f3d..3d6ac4f 100644
--- a/drivers/staging/android/ion/ion_page_pool.c
+++ b/drivers/staging/android/ion/ion_page_pool.c
@@ -45,10 +45,10 @@ static int ion_page_pool_add(struct ion_page_pool *pool, struct page *page)
        if (PageHighMem(page)) {
-               list_add_tail(&page->lru, &pool->high_items);
+               list_add(&page->lru, &pool->high_items);
        } else {
-               list_add_tail(&page->lru, &pool->low_items);
+               list_add(&page->lru, &pool->low_items);

More information about the devel mailing list