[PATCH] staging: comedi: me4000: fix firmware downloading

Ian Abbott abbotti at mev.co.uk
Fri Oct 24 10:18:32 UTC 2014


On 23/10/14 20:19, H Hartley Sweeten wrote:
> Convert this driver to use comedi_load_firmware() to download the firmware
> to the board.
>
> Signed-off-by: H Hartley Sweeten <hsweeten at visionengravers.com>
> Cc: Ian Abbott <abbotti at mev.co.uk>
> Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> ---
>   drivers/staging/comedi/drivers/me4000.c | 93 ++++++++++++++-------------------
>   1 file changed, 40 insertions(+), 53 deletions(-)

It's fine as an adaptation of the currently disabled code, although the 
original firmware loading code could do with some improvement (sanity 
checking the firmware data length, and checking the BUSY bit more 
frequently to hopefully speed it the loading process).

Reviewed-by: Ian Abbott <abbotti at mev.co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-


More information about the devel mailing list