[PATCH 00/91] staging: unisys: clean up include and common-spar

Benjamin Romer benjamin.romer at unisys.com
Thu Oct 23 18:29:39 UTC 2014


This patch series fixes nearly all of the strict checks, warnings, and errors
generated by the files in the unisys/include and unisys/common-spar trees.
Aside from include/procobjectree.h, which will be removed as soon as possible,
all of these files should be free of errors and warnings that cannot be
justified (string constants over 80 character limit, for instance).

Benjamin Romer (91):
  staging: unisys: clean up bracing in vbuschannel_sanitize_buffer()
  staging: unisys: fix indentation on vbuschannel_devinfo_to_string()
  staging: unisys: clean up extra parens in
    vbuschannel_devinfo_to_string
  staging: unisys: delete extra space character in vbuschannel_itoa()
  staging: unisys: fix typedef for VMCALL_MONITOR_INTERFACE_METHOD_TUPLE
  staging: unisys: fix CamelCase in ISSUE_IO_VMCALL macros
  staging: unisys: get rid of IO_DATA_STRUCTURE typedef
  staging: unisys: fix CamelCase channel constants
  staging: unisys: clean up stray blank lines in channel_guid.h
  staging: unisys: remove channel mismatch macros
  staging: unisys: get rid of UltraLogEvent macro
  staging: unisys: remove typedef for CHANNEL_SERVERSTATE
  staging: unisys: get rid of typedef for CHANNEL_CLIENTSTATE
  staging: unisys: fix missing blank line after enum channel_clientstate
  staging: unisys: fix spacing in ULTRA_CHANNELCLI_STRING
  staging: unisys: remove typedef for CHANNEL_HEADER
  staging: unisys: fix CamelCase names in struct channel_header
  staging: unisys: clean up ULTRA_CHANNEL_SERVER_READY macro
  staging: unisys: fix ULTRA_SPAR_CHANNEL_CLIENT_CHK_TRANSITION macro
  staging: unisys: fix CamelCase in PathName_Last_N_Nodes()
  staging: unisys: fix up ULTRA_CHANNEL_CLIENT_TRANSITION macro
  staging: unisys: refactor ULTRA_channel_client_acquire_os()
  staging: unisys: refactor ULTRA_channel_client_release_os()
  staging: unisys: remove typedef SIGNAL_QUEUE_HEADER
  staging: unisys: fix CamelCase in struct signal_queue_header
  staging: unisys: refactor ULTRA_check_channel_client()
  staging: unisys: refactor visor_signal_remove()
  staging: unisys: refactor visor_signalqueue_empty()
  staging: unisys: fix symbol placement in spar_channel_client_acquire
  staging: unisys: refactor SignalInit Macro
  staging: unisys: refactor SignalRemoveAll()
  staging: unisys: refactor ULTRA_check_channel_server()
  staging: unisys: refactor ultra_segment_state
  staging: unisys: fix CamelCase constant names in controlframework.h
  staging: unisys: refactor UltraControlvmChannelProtocolGuid
  staging: unisys: remove ULTRA_CONTROLVM_CHANNEL_OK_SERVER macro
  staging: unisys: fix CamelCase in SPAR_CONTROLVM_CHANNEL_OK_CLIENT
  staging: unisys: remove typedef CONTROLVM_ID
  staging: unisys: fix CamelCase names in struct irq_info
  staging: unisys: fix CamelCase names in struct pci_id
  staging: unisys: remove unused code from controlvmchannel.h
  staging: unisys: replace typedef ULTRA_EFI_SPAR_INDICATION
  staging: unisys: fix CamelCase names in struct efi_spar_indication
  staging: unisys: fix CamelCase macro names in controlframework.h
  staging: unisys: refactor ULTRA_CHIPSET_FEATURE enum
  staging: unisys: refactor CONTROLVM_MESSAGE_PACKET
  staging: unisys: refactor CONTROLVM_MESSAGE_HEADER
  staging: unisys: refactor CONTROLVM_PACKET_DEVICE_CREATE
  staging: unisys: refactor CONTROLVM_PACKET_DEVICE_CONFIGURE
  staging: unisys: refactor CONTROLVM_MESSAGE_DEVICE_CREATE
  staging: unisys: refactor CONTROLVM_MESSAGE_DEVICE_CONFIGURE
  staging: unisys: remove typedef from CONTROLVM_MESSAGE
  staging: unisys: refactor DEVICE_MAP
  staging: unisys: refactor GUEST_DEVICES
  staging: unisys: refactor SPAR_CONTROLVM_CHANNEL_PROTOCOL
  staging: unisys: refactor ULTRA_CONTROLVM_PARAMETERS_HEADER
  staging: unisys: fix misspelled word in controlvmchannel.h
  staging: unisys: refactor UltraDiagChannelProtocolGuid
  staging: unisys: refactor ULTRA_DIAG_CHANNEL_OK_CLIENT
  staging: unisys: refactor ULTRA_DIAG_CHANNEL_OK_SERVER
  staging: unisys: refactor DIAG_EFI_TIME
  staging: unisys: refactor ULTRA_COMPONENT_TYPES
  staging: unisys: refactor DIAG_CHANNEL_EVENT
  staging: unisys: remove typedef for DIAG_SEVERITY
  staging: unisys: remove extra blank lines in diagchannel.h
  staging: unisys: remove typedef from DIAG_CAUSE
  staging: unisys: refactor DIAG_CHANNEL_PROTOCOL_HEADER
  staging: unisys: refactor ULTRA_DIAG_CHANNEL_PROTOCOL
  staging: unisys: clean up line spacing in iochannel.h
  staging: unisys: fix typecast spacing in iochannel.h
  staging: unisys: clean up CamelCase parameter in
    SPAR_VHBA_CHANNEL_OK_CLIENT
  staging: unisys: remove unused macro ULTRA_VHBA_CHANNEL_OK_SERVER
  staging: unisys: remove unused macro ULTRA_VNIC_CHANNEL_OK_SERVER
  staging: unisys: remove unused macro ULTRA_VSWITCH_CHANNEL_OK_SERVER
  staging: unisys: fix parameters to macro SPAR_VNIC_CHANNEL_OK_CLIENT
  staging: unisys: remove unused macro SPAR_VSWITCH_CHANNEL_OK_CLIENT
  staging: unisys: remove typedef from NET_TYPES
  staging: unisys: fix CamelCase in ETH_IS_LOCALLY_ADMINISTERED
  staging: unisys: refactor TASK_MGMT_TYPES
  staging: unisys: refactor enum VDISK_MGMT_TYPES
  staging: unisys: fix CamelCase names in struct sense_data
  staging: unisys: fix CamelCase name in net_pkt_rcvpost
  staging: unisys: fix CamelCase names in net_pkt_rcv
  staging: unisys: fix CamelCase in uiscmdrsp_disknotify
  staging: unisys: refactor ULTRA_IO_CHANNEL_PROTOCOL
  staging: unisys: remove unused code from iochannel.h
  staging: unisys: clean up UltraVbusChannelProtocol
  staging: unisys: fix parameters for SPAR_VBUS_CHANNEL_OK_CLIENT macro
  staging: unisys: refactor ULTRA_VBUS_CHANNEL_OK_SERVER
  staging: unisys: refactor ULTRA_VBUS_HEADERINFO
  staging: unisys: refactor struct struct ultra_vbus_channel_protocol

 .gitignore                                         |   4 +
 drivers/staging/unisys/channels/channel.c          | 114 ++--
 drivers/staging/unisys/channels/chanstub.c         |   8 +-
 drivers/staging/unisys/channels/chanstub.h         |   8 +-
 .../unisys/common-spar/include/channels/channel.h  | 505 +++++++----------
 .../common-spar/include/channels/channel_guid.h    |  27 +-
 .../include/channels/controlframework.h            |  31 +-
 .../include/channels/controlvmchannel.h            | 617 +++++++++------------
 .../common-spar/include/channels/diagchannel.h     | 168 +++---
 .../common-spar/include/channels/iochannel.h       | 288 +++-------
 .../common-spar/include/channels/vbuschannel.h     |  65 ++-
 .../unisys/common-spar/include/vbusdeviceinfo.h    |  19 +-
 .../unisys/common-spar/include/vmcallinterface.h   |  13 +-
 drivers/staging/unisys/include/uisqueue.h          |   6 +-
 drivers/staging/unisys/include/uisutils.h          |   3 +-
 drivers/staging/unisys/uislib/uislib.c             | 296 +++++-----
 drivers/staging/unisys/uislib/uisqueue.c           |   8 +-
 drivers/staging/unisys/virthba/virthba.c           |  72 +--
 drivers/staging/unisys/virtpci/virtpci.c           |  66 +--
 .../unisys/visorchannel/visorchannel_funcs.c       | 197 +++----
 drivers/staging/unisys/visorchipset/file.c         |   6 +-
 drivers/staging/unisys/visorchipset/parser.c       |  50 +-
 drivers/staging/unisys/visorchipset/testing.h      |   5 +-
 drivers/staging/unisys/visorchipset/visorchipset.h |  19 +-
 .../unisys/visorchipset/visorchipset_main.c        | 536 +++++++++---------
 25 files changed, 1397 insertions(+), 1734 deletions(-)

-- 
1.9.1



More information about the devel mailing list