[PATCH 00/22] staging: comedi: addi_apci_3120: additional clean up

[Ian Abbott]

On 20/10/14 19:34, H Hartley Sweeten wrote:
> More cleanup of the addi_apci_3120 driver.
>
> These apply after:
>    [PATCH 00/34] staging: comedi: addi-data: remove "common" code bloat
>
> H Hartley Sweeten (22):
>    staging: comedi: addi_apci_3120: DMA requires an interrupt
>    staging: comedi: addi_apci_3120: introduce struct apci3120_dmabuf
>    staging: comedi: addi_apci_3120: remove unused struct definition
>    staging: comedi: addi_apci_3120: remove unipolar range from analog outputs
>    staging: comedi: addi_apci_3120: remove private data 'i_IobaseReserved'
>    staging: comedi: addi_apci_3120: use correct iobase to write AMCC registers
>    staging: comedi: addi_apci_3120: use correct iobase to read board register
>    staging: comedi: addi_apci_3120: rename private data 'i_IobaseAddon'
>    staging: comedi: addi_apci_3120: rename private data 'i_IobaseAmcc'
>    staging: comedi: addi_apci_3120: remove private data 'iobase'
>    staging: comedi: addi_apci_3120: prevent deadlock in apci3120_ao_insn_write()
>    staging: comedi: addi_apci_3120: remove analog output reset
>    staging: comedi: addi_apci_3120: fix apci3120_ao_insn_write()
>    staging: comedi: addi_apci_3120: provide analog output 'readback'
>    staging: comedi: addi_apci_3120: tidy up analog output subdevice init
>    staging: comedi: addi_apci_3120: tidy up digital input subdevice init
>    staging: comedi: addi_apci_3120: tidy up digital output subdevice init
>    staging: comedi: addi_apci_3120: tidy up analog input subdevice init
>    staging: comedi: addi_apci_3120: tidy up timer subdevice init
>    staging: comedi: addi_apci_3120: reset the board before hooking up the interrupt
>    staging: comedi: addi_apci_3120: don't reset board when canceling ai command
>    staging: comedi: addi_apci_3120: don't reset board when detaching driver
>
>   .../comedi/drivers/addi-data/hwdrv_apci3120.c      | 469 ++++++++-------------
>   drivers/staging/comedi/drivers/addi_apci_3120.c    | 238 ++++++-----
>   2 files changed, 317 insertions(+), 390 deletions(-)
>

Now that the AO subdevice supports "readback" via the insn_read handler, 
it would be nice to initialize the analog outputs and readback values so 
they match during auto_attach (see my comment on patch 12).  But that 
can be added later.

Reviewed-by: Ian Abbott <abbotti at mev.co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-