[PATCH] staging: comedi: ni_6527: remove deadcode in ni6527_intr_cmdtest()

Ian Abbott abbotti at mev.co.uk
Tue Oct 21 15:19:13 UTC 2014


On 20/10/14 23:03, H Hartley Sweeten wrote:
> Reported by: coverity (CID 142962)

There should be a dash in "Reported by".  Not sure if it matters.

> Signed-off-by: H Hartley Sweeten <hsweeten at visionengravers.com>
> Cc: Ian Abbott <abbotti at mev.co.uk>
> Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> ---
>   drivers/staging/comedi/drivers/ni_6527.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/ni_6527.c b/drivers/staging/comedi/drivers/ni_6527.c
> index 1a62b4f..f99847f 100644
> --- a/drivers/staging/comedi/drivers/ni_6527.c
> +++ b/drivers/staging/comedi/drivers/ni_6527.c
> @@ -237,9 +237,6 @@ static int ni6527_intr_cmdtest(struct comedi_device *dev,
>   	/* Step 2a : make sure trigger sources are unique */
>   	/* Step 2b : and mutually compatible */
>
> -	if (err)
> -		return 2;
> -
>   	/* Step 3: check if arguments are trivially valid */
>
>   	err |= cfc_check_trigger_arg_is(&cmd->start_arg, 0);
>

Other than the issue with the "Reported by" line...

Reviewed-by: Ian Abbott <abbotti at mev.co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-


More information about the devel mailing list