[PATCH] staging: comedi: ni_65xx: remove deadcode in ni_65xx_intr_cmdtest()

Ian Abbott abbotti at mev.co.uk
Tue Oct 21 15:17:05 UTC 2014


On 21/10/14 16:14, Ian Abbott wrote:
> On 20/10/14 23:02, H Hartley Sweeten wrote:
>> Reported by: coverity (CID 142963)
>> Signed-off-by: H Hartley Sweeten <hsweeten at visionengravers.com>
>> Cc: Ian Abbott <abbotti at mev.co.uk>
>> Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
>> ---
>>   drivers/staging/comedi/drivers/ni_65xx.c | 3 ---
>>   1 file changed, 3 deletions(-)
>>
>> diff --git a/drivers/staging/comedi/drivers/ni_65xx.c
>> b/drivers/staging/comedi/drivers/ni_65xx.c
>> index 195b10b..bcb326e 100644
>> --- a/drivers/staging/comedi/drivers/ni_65xx.c
>> +++ b/drivers/staging/comedi/drivers/ni_65xx.c
>> @@ -534,9 +534,6 @@ static int ni_65xx_intr_cmdtest(struct
>> comedi_device *dev,
>>       /* Step 2a : make sure trigger sources are unique */
>>       /* Step 2b : and mutually compatible */
>>
>> -    if (err)
>> -        return 2;
>> -
>>       /* Step 3: check if arguments are trivially valid */
>>
>>       err |= cfc_check_trigger_arg_is(&cmd->start_arg, 0);
>>
>
> Reviewed-by: Ian Abbott <abbotti at mev.co.uk>

Although there ought to be a dash in your "Reported by:" line, Hartley.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-


More information about the devel mailing list