linux-3.18-rc1 bug report

[Mark Hounschell]

On 10/21/2014 07:33 AM, David Binderman wrote:
> Hello there,
>
> 1.
>
> [linux-3.18-rc1/drivers/staging/dgap/dgap.c:6692]: (warning) Logical disjunction always evaluates to true: conc_type != 65 || conc_type != 66.
>
> Source code is
>
>              if (conc_type == 0 || conc_type != CX ||
>                  conc_type != EPC) {
>
> 2.
>
> [linux-3.18-rc1/drivers/staging/dgap/dgap.c:6733]: (warning) Logical disjunction always evaluates to true: module_type != 68 || module_type != 73.
>
>              if (module_type == 0 || module_type != PORTS ||
>                  module_type != MODEM) {
>
> Suggest code rework in both cases
>
> Regards
>
> David Binderman

Yes, this is certainly wrong. Eventually, all that code parsing the 
config file will have to be removed. Those above 2 sections particularly 
because I don't see any way to support the concentrators at the moment.

Thanks
Mark