[PATCH v2] bcm/CmHost.c: Fix noisy compile warnings

Greg KH gregkh at linuxfoundation.org
Thu Oct 16 08:13:07 UTC 2014


On Wed, Oct 15, 2014 at 03:59:21PM -0700, Jeff Kirsher wrote:
> On Wed, 2014-10-15 at 12:01 -0700, Jeff Kirsher wrote:
> > From: Fabio Estevam <fabio.estevam at freescale.com>
> > 
> > The Beceem WIMAX was generating compile warnings on 64bit machines,
> > which were:
> > 
> > drivers/staging/bcm/CmHost.c: In function ‘StoreCmControlResponseMessage’:
> > drivers/staging/bcm/CmHost.c:1503:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> >    (struct bcm_connect_mgr_params *) ntohl(
> >    ^
> > drivers/staging/bcm/CmHost.c:1546:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> >    (struct bcm_connect_mgr_params *) ntohl(
> >    ^
> > drivers/staging/bcm/CmHost.c:1564:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> >    (struct bcm_connect_mgr_params *) ntohl(
> > 
> > This resolves the issue by preventing the driver to compile if CONFIG_64BIT
> > is enabled, since the driver is known to be broken for 64 bit arch's.
> > 
> > CC: Dan Carpenter <dan.carpenter at oracle.com>
> > CC: Joe Perches <joe at perches.com>
> > Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher at intel.com>
> 
> Greg- I have also submitted a patch to remove this driver entirely.  So
> if you choose to apply the patch to remove the driver, then you can
> disregard this patch.

Thanks, I'll take that removal patch now, I'm glad to get rid of that
mess.

greg k-h


More information about the devel mailing list