[PATCH 00/34] staging: comedi: addi-data: remove "common" code bloat

[Ian Abbott]

On 14/10/14 18:44, H Hartley Sweeten wrote:
> The ADDI-DATA drivers all originally use some "common" code to provide the
> comedi driver attach/detach. This "common" code added a lot of bloat to the
> drivers due to the boardinfo and private data definitions. Most of the
> ADDI-DATA drivers have been separated from this "commont" code and now have
> private definitions for the boardinfo, if it's even needed, and the private
> data used by the driver. They also have private attach/detach functions and
> the bloat has been removed.
>
> This series separates the remaining ADDI-DATA drivers from the "common"
> code and removes the "common" code completely. It also removes the unneeded
> boardinfo from the addi_apci_035 and addi_apci_1500 drivers and trims down
> the boardinfo in the addi_apci_3120 driver.
>
> H Hartley Sweeten (34):
>    staging: comedi: addi_common.c: remove i_ADDI_Detach()
>    staging: comedi: addi_common.c: remove i_ADDI_Reset()
>    staging: comedi: addi_common.c: remove addi_auto_attach()
>    staging: comedi: addi_common.c: remove v_ADDI_Interrupt()
>    staging: comedi: addi_common.c: remove included source file
>    staging: comedi: addi_apci_035: remove subdevice callbacks from boardinfo
>    staging: comedi: addi_apci_1500: remove subdevice callbacks from boardinfo
>    staging: comedi: addi_common.h: remove subdevice callbacks from struct addi_board
>    staging: comedi: addi_apci_035: remove unnecessary subdevice initialization
>    staging: comedi: addi_apci_035: remove unused subdevices
>    staging: comedi: addi_apci_1500: remove unnecessary subdevice initialization
>    staging: comedi: addi_apci_1500: remove unused subdevices
>    staging: comedi: addi_common.h: rename boardinfo 'pc_DriverName'
>    staging: comedi: addi_common.h: remove boardinfo 'i_IorangeBase1'
>    staging: comedi: addi_apci_1500: remove eeprom support
>    staging: comedi: addi_apci_035: board has eeprom
>    staging: comedi: addi_common.h: remove boardinfo member 'i_PCIEeprom'
>    staging: comedi: addi_apci_1500: remove boardinfo
>    staging: comedi: addi_apci_035: remove boardinfo
>    staging: comedi: addi_eeprom: remove source file
>    staging: comedi: hwdrv_apci3120: remove need for boardinfo access
>    staging: comedi: addi_common.h: remove boardinfo definition
>    staging: comedi: addi_common.h: remove unused members from addi_private
>    staging: comedi: addi_apci_3120: remove boardinfo 'i_DoMaxdata'
>    staging: comedi: addi_apci_3120: remove boardinfo 'i_NbrDoChannel'
>    staging: comedi: addi_apci_3120: remove boardinfo 'i_NbrDiChannel'
>    staging: comedi: addi_apci_3120: remove boardinfo 'i_NbrAiChannel'
>    staging: comedi: addi_apci_3120: remove boardinfo 'i_AiChannelList'
>    staging: comedi: addi_apci_3120: simplify analog output boardinfo
>    staging: comedi: addi_apci_3120: simplify analog input boardinfo
>    staging: comedi: addi_apci_035: separate from addi_common.h
>    staging: comedi: addi_apci_1500: separate from addi_common.h
>    staging: comedi: addi_apci_3120: separate from addi_common.h
>    staging: comedi: addi_common.h: remove file
>
>   .../staging/comedi/drivers/addi-data/addi_common.c | 274 ----------------
>   .../staging/comedi/drivers/addi-data/addi_common.h | 144 ---------
>   .../staging/comedi/drivers/addi-data/addi_eeprom.c | 360 ---------------------
>   .../comedi/drivers/addi-data/hwdrv_apci035.c       |  18 +-
>   .../comedi/drivers/addi-data/hwdrv_apci1500.c      |  28 +-
>   .../comedi/drivers/addi-data/hwdrv_apci3120.c      |  60 ++--
>   drivers/staging/comedi/drivers/addi_apci_035.c     | 112 +++++--
>   drivers/staging/comedi/drivers/addi_apci_1500.c    | 118 +++++--
>   drivers/staging/comedi/drivers/addi_apci_3120.c    | 109 ++++---
>   9 files changed, 279 insertions(+), 944 deletions(-)
>   delete mode 100644 drivers/staging/comedi/drivers/addi-data/addi_common.c
>   delete mode 100644 drivers/staging/comedi/drivers/addi-data/addi_common.h
>   delete mode 100644 drivers/staging/comedi/drivers/addi-data/addi_eeprom.c
>

Reviewed-by: Ian Abbott <abbotti at mev.co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-