[PATCH net-next, v2] hyperv: Add handling of IP header with option field in netvsc_set_hash()
haiyangz at microsoft.com
Tue Oct 14 21:47:33 UTC 2014
> -----Original Message-----
> From: David Miller [mailto:davem at davemloft.net]
> Sent: Tuesday, October 14, 2014 5:37 PM
> To: Haiyang Zhang
> Cc: netdev at vger.kernel.org; KY Srinivasan; olaf at aepfle.de;
> jasowang at redhat.com; linux-kernel at vger.kernel.org; driverdev-
> devel at linuxdriverproject.org
> Subject: Re: [PATCH net-next,v2] hyperv: Add handling of IP header with option
> field in netvsc_set_hash()
> From: Haiyang Zhang <haiyangz at microsoft.com>
> Date: Tue, 14 Oct 2014 15:16:28 -0700
> > In case that the IP header has optional field at the end, this patch
> > will get the port numbers after that field, and compute the hash.
> > Signed-off-by: Haiyang Zhang <haiyangz at microsoft.com>
> > Reviewed-by: K. Y. Srinivasan <kys at microsoft.com>
> Instead of adding hack after hack after hack to your internal header parser, just
> use the generic flow dissector we already have in the kernel to fetch out the
> values you need.
> __skb_flow_get_ports() etc.
Thanks. I will update the patch.
More information about the devel