[PATCH 0/2] staging: comedi: tidy up the async event defines

Ian Abbott abbotti at mev.co.uk
Tue Oct 14 08:53:27 UTC 2014


On 13/10/14 17:56, H Hartley Sweeten wrote:
> The async event defines, COMEDI_CB_*, are only used in the kernel. They should
> not be exposed to userspace in the comedi.h uapi header. Move the defines to
> the comedidev.h kernel header and tidy up the documentation.
>
> Also, introduce some mask defines to clarify the events that indicate error
> conditions and that cancel an async command.
>
> H Hartley Sweeten (2):
>    staging: comedi: comedidev.h: don't expose COMEDI_CB_* defines to userspace
>    staging: comedi: comedidev.h: clarify async->event error/cancel detection
>
>   drivers/staging/comedi/comedi.h               | 11 -----------
>   drivers/staging/comedi/comedi_fops.c          | 18 ++++++++----------
>   drivers/staging/comedi/comedidev.h            | 22 ++++++++++++++++++++++
>   drivers/staging/comedi/drivers.c              |  2 +-
>   drivers/staging/comedi/drivers/amplc_pci230.c | 10 ++--------
>   5 files changed, 33 insertions(+), 30 deletions(-)
>

Reviewed-by: Ian Abbott <abbotti at mev.co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-


More information about the devel mailing list