[PATCH] staging: bcm: remove unnecessary else statement

Greg KH gregkh at linuxfoundation.org
Wed Oct 8 22:40:23 UTC 2014


On Tue, Sep 30, 2014 at 11:29:00PM +0530, Karthik Nayak wrote:
> Removed the else statement occurring after an if statement with a
> return value as per checkpatch warning.
> 
> Signed-off-by: Karthik Nayak <karthik.188 at gmail.com>
> ---
>  drivers/staging/bcm/InterfaceMisc.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/bcm/InterfaceMisc.c b/drivers/staging/bcm/InterfaceMisc.c
> index e5bcfec..1f31b8f 100644
> --- a/drivers/staging/bcm/InterfaceMisc.c
> +++ b/drivers/staging/bcm/InterfaceMisc.c
> @@ -102,12 +102,11 @@ int InterfaceWRM(struct bcm_interface_adapter *psIntfAdapter,
>  				DBG_LVL_ALL, "WRM failed status :%d", retval);
>  		psIntfAdapter->psAdapter->DeviceAccess = false;
>  		return retval;
> -	} else {
> -		psIntfAdapter->psAdapter->DeviceAccess = false;
> -		BCM_DEBUG_PRINT(psIntfAdapter->psAdapter, DBG_TYPE_OTHERS, WRM,
> -				DBG_LVL_ALL, "WRM sent %d", retval);
> -		return STATUS_SUCCESS;
>  	}
> +	psIntfAdapter->psAdapter->DeviceAccess = false;
> +	BCM_DEBUG_PRINT(psIntfAdapter->psAdapter, DBG_TYPE_OTHERS, WRM,
> +			DBG_LVL_ALL, "WRM sent %d", retval);
> +	return STATUS_SUCCESS;
>  }
>  
>  int BcmRDM(void *arg,
> -- 
> 2.1.0

This doesn't apply either, someone else must have done this change
already.


More information about the devel mailing list