[PATCH v4 1/4] Documentation: devicetree: bindings: Document correct and deprecated vendor-prefix with device isl29028

Mark Rutland mark.rutland at arm.com
Tue Oct 7 15:36:29 UTC 2014


Hi Darshana,

On Tue, Oct 07, 2014 at 04:19:26PM +0100, Darshana Padmadas wrote:
> This patch documents the device isl29028 with its vendor-prefix. Undocumented deprecated vendor-prefix
> found by checkpatch also documented for compatibility reasons.
> 
> Signed-off-by: Darshana Padmadas <darshanapadmadas at gmail.com>

In future, when you receive an Acked-by (or Reviewed-by, Tested-by,
etc), please add them here for subsequent postings, unless there have
been substantial changes that mean said tags are not representative. For
example, this patch you should have:

Signed-off-by: Darshana Padmadas <darshanapadmadas at gmail.com>
Acked-by: Arnd Bergmann <arnd at arndb.de>
Acked-by: Mark Rutland <mark.rutland at arm.com>

That makes it obvious that others have looked at your patches, and will
help maintainers when deciding whether to pick them up. Additionally,
for those who have reviewed or tested patches, it gains them some
recognition for that effort.

Additionally, it's generally a good idea to wait for at least a day or
so between postings so as to give others time to inspect patches.

Thanks,
Mark.

> ---
>  Documentation/devicetree/bindings/i2c/trivial-devices.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
> index 6af570e..32edf0b 100644
> --- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt
> +++ b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
> @@ -57,6 +57,8 @@ gmt,g751		G751: Digital Temperature Sensor and Thermal Watchdog with Two-Wire In
>  infineon,slb9635tt	Infineon SLB9635 (Soft-) I2C TPM (old protocol, max 100khz)
>  infineon,slb9645tt	Infineon SLB9645 I2C TPM (new protocol, max 400khz)
>  isl,isl12057		Intersil ISL12057 I2C RTC Chip
> +isil,isl29028           (deprecated, use isl)
> +isl,isl29028            Intersil ISL29028 Ambient Light and Proximity Sensor
>  maxim,ds1050		5 Bit Programmable, Pulse-Width Modulator
>  maxim,max1237		Low-Power, 4-/12-Channel, 2-Wire Serial, 12-Bit ADCs
>  maxim,max6625		9-Bit/12-Bit Temperature Sensors with I²C-Compatible Serial Interface
> -- 
> 1.9.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel


More information about the devel mailing list