[PATCH 1/5] Combine ifs into one where possible to avoid unnecessary indentation level increase

Greg KH gregkh at linuxfoundation.org
Fri Oct 3 20:34:13 UTC 2014


On Fri, Oct 03, 2014 at 11:27:04PM +0300, Giedrius Statkevicius wrote:
> From: Giedrius Statkevičius <giedrius.statkevicius at gmail.com>
> 
> Join together chained if's where possible to lower the indentation level.
> 
> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius at gmail.com>

Your subject is "odd", in that it doesn't say what part of the kernel it
is for.  Look at the kernel git logs, it should give you an idea of how
to format things properly.

Also, you don't have to have such a long subject:, try to keep it short,
and then be verbose in the changelog body.

Can you fix up all of these 5 and resend?

thanks,

greg k-h


More information about the devel mailing list